-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sdk to 14, improve types #144
base: master
Are you sure you want to change the base?
Conversation
166e23d
to
54bf693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
onDisconnect: () => alert("Aepp is disconnected"), | ||
async function setupWalletConnector() { | ||
status.value = Status.WALLET_SCANNING; | ||
disconnectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add await or void for this async function call
} | ||
} | ||
|
||
updateConnectionInfo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add await or void for this async function call
) { | ||
status.value = Status.UNINITIALIZED; | ||
if (customNodeUrl) nodeUrl.value = customNodeUrl; | ||
else nodeUrl.value = nodes[0].instance.$host; | ||
disconnectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add await or void for this async function call
This PR is supported by the Æternity Foundation