Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop bootstrap #1124

Merged
merged 3 commits into from
Jul 6, 2021
Merged

refactor: drop bootstrap #1124

merged 3 commits into from
Jul 6, 2021

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jul 3, 2021

closes #740

@Liubov-crypto would be nice to ensure that it doesn't add any significant visual bugs in both mobile and desktop

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Jul 5, 2021

Tested in mobile and desktop browsers, in general LGTM:
Trending - pass
Search - pass
Change profile/back pics - pass
Change profile info - pass
Cookies - pass
Send Tip on the Feed - pass
Retip on the feed - pass
Post without tipping - pass
Comment - pass
Tip comment on the feed - pass
Pin/Unpin - pass
Claim - pass
Report post - pass
Voting - pass
Vote - pass
Revoke Vote - pass
Delegate voting power - pass
Create a new poll - pass
Search - pass
Meet - pass
Updates - pass
Faq- pass

also remains #1112
Not synced names in Meet UI and SH wallet.

I haven't been using the wallet for a while, got this error. But maybe this is the wallet side (#1180 in wallet issues):
not using wallet a while

conss

It is possible to move the wallet to the left in the mobile browser:
зображення_viber_2021-07-05_18-13-34

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voting does not sync with the wallet and it is impossible to make a transaction (mobile browser):
Wire 2021-07-05 at 16-39-26

@davidyuk
Copy link
Member Author

davidyuk commented Jul 6, 2021

It is possible to move the wallet to the left in the mobile browser

This issue persists in develop branch, so fixing it separately in #1127

All other issues seems to be resolved

@davidyuk davidyuk merged commit 9aeca0d into develop Jul 6, 2021
@davidyuk davidyuk deleted the feature/drop-bootstrap branch July 6, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the status of Bootstrap in this project?
3 participants