Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search function to Data.List.Relation.Unary.All #2428

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jul 4, 2024

Fixes #989

NB. UPDATED CHANGELOG added

  • In Data.List.Relation.Unary.All:
    search : Decidable P   xs  All (∁ P) xs ⊎ Any P xs

@JacquesCarette
Copy link
Contributor

I'd approve if there were a CHANGELOG.

@jamesmckinna
Copy link
Contributor Author

I'd approve if there were a CHANGELOG.

Currently all the v2.2-badged PRs I'm posting (or reviewing ;-)) are without CHANGELOG, against the inevitable reset after the eventual v2.1 release...

@mildsunrise
Copy link
Contributor

maybe it would ease some burden for everyone if we started special branches for every release, i.e. v2.1, and we could keep working on master for the next minor (or even major) release?

src/Data/List/Relation/Unary/All.agda Outdated Show resolved Hide resolved
src/Data/List/Relation/Unary/All.agda Outdated Show resolved Hide resolved
@jamesmckinna
Copy link
Contributor Author

maybe it would ease some burden for everyone if we started special branches for every release, i.e. v2.1, and we could keep working on master for the next minor (or even major) release?

That sounds good, so shoutout to the release-Meister @MatthewDaggitt for comment!? (The actual machinery of producing a release is still a bit mysterious to me...)

Copy link
Member

@Taneb Taneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending changelog

@MatthewDaggitt
Copy link
Contributor

Yup happy to create a release branch. We've never really had the quantity of contributors around a release time that made it a necessity before.

@jamesmckinna
Copy link
Contributor Author

Yup happy to create a release branch. We've never really had the quantity of contributors around a release time that made it a necessity before.

But let's capitalise on the momentum that our new (and old!) contributors are bringing to the development process!?

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Jul 11, 2024

Notwithstanding the approvals (for which all thanks), I'm wondering if a sharper lemma should (instead) be provable, namely that for Decidable P, we can exhibit a view of any given list xs as either All (not P) xs or All (not P) ys and Any P zs for a prefix decomposition ys ++ zs of xs (while trying to prove the equivalence of various definitions of deleteFirst against #988 ...)

... but such a thing could in any case have a 'better' name, such as prefixSearch or searchFirst, so could/should be orthogonal to this PR!?

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Jul 26, 2024

CHANGELOG entry added on the blank v2.2-dev template inherited from #2439 ... so a successful merge of that PR should see a more sensible diff/patch for this one... and resolve the newly-introduced merge conflict ;-)/:-(

@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Aug 14, 2024
Merged via the queue into agda:master with commit 61e7707 Aug 14, 2024
2 checks passed
@jamesmckinna jamesmckinna deleted the issue989 branch August 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

searching in list
5 participants