-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename homo
to ∙-homo
in Algebra.Morphism.Structures
#2464
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - but isn't this a breaking change?
I forget (or: have never properly understood?!) whether changing (field) names via deprecation is |
Yes, unfortunately it is an unavoidable breaking change. |
Fixes #2458
NB: the warning-on-usage does not seem to be correctly triggering when reference to
homo
is made inrenaming
directives, nor in actual usage? UPDATED: A known, but not-yet-fixed, Agda bug. Grrrr.