Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tuple implementation #239

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Simplify tuple implementation #239

merged 1 commit into from
Dec 4, 2023

Conversation

flupe
Copy link
Contributor

@flupe flupe commented Dec 4, 2023

Implements #228, fixes #215.

There's no longer Tuple parametrized by a list of types, nor Pair. Just _x_ and _x_x_. We cannot pattern-match in let bindings on _x_x_ because it's not a record, so no erroneous projections anymore.

We could add _x_x_x_ but Agda will probably not parse it.

@flupe flupe linked an issue Dec 4, 2023 that may be closed by this pull request
@flupe flupe requested a review from jespercockx December 4, 2023 18:12
@jespercockx jespercockx merged commit cc79050 into agda:master Dec 4, 2023
6 checks passed
@jespercockx jespercockx added this to the 1.2 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "smart" generic tuple handling Tuple projection bug
2 participants