Normal form of FreeGroup #1099
Merged
Normal form of FreeGroup #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you aware of the parallel PR: |
|
I have groupoid solver in works, it is intended as just slight extension of
group solver.
…On Wed, Feb 7, 2024, 10:48 AM Felix Cherubini ***@***.***> wrote:
Are you aware of the parallel PR:
#1093 <#1093>
where I try to improve the reflection code of the ringSolver a bit. Maybe
there is a chance to share some code?
Something completely different: Do you know if it is substantially harder
to write a groupoid-solver instead of a group solver?
—
Reply to this email directly, view it on GitHub
<#1099 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQZARWILQAC534N7YZO5DLYSNEX3AVCNFSM6AAAAABC3ZQM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRGY3DKOBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
felixwellen
reviewed
Feb 14, 2024
|
I removed solvers part, so that PR is only about abstract results
I am opening seperate PR for WIldCatSolver wich can be specialised both for Groups and Groupoids |
marcinjangrzybowski
changed the title
|
I am still working towards a wild cat solver, starting with free wild cats here: #1117 |
|
I made an issue which we can use to coordinate: #1118 |
felixwellen
requested changes
Mar 25, 2024
felixwellen
approved these changes
Apr 11, 2024
|
Is it ready to merge? |
|
yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everythings work at the moment, I will request review once I will add some comments.