-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommAlgebras as CommRingHoms #1145
Draft
felixwellen
wants to merge
83
commits into
master
Choose a base branch
from
fwellen/ring_with_hom_algebras
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
5 times, most recently
from
August 2, 2024 16:22
8a04a53
to
e997ccd
Compare
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
3 times, most recently
from
August 7, 2024 15:16
5abb334
to
72226e5
Compare
I did some random benchmarking (this PR is not really about type checking speed, but I made some changes while I rewrote code). In summary, the two modules in CommAlgebra with comparable content have signficantly lower type checking times now, while there is no significant change for the modules in Ring and CommRing I checked.
|
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
2 times, most recently
from
September 2, 2024 07:58
e3cae56
to
04adbaf
Compare
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
from
September 30, 2024 12:27
04adbaf
to
1cb7ca5
Compare
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
from
September 30, 2024 16:30
1cb7ca5
to
e62abab
Compare
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
from
October 1, 2024 09:13
e62abab
to
bc7a252
Compare
felixwellen
force-pushed
the
fwellen/ring_with_hom_algebras
branch
from
October 16, 2024 15:29
8abc7a4
to
7917b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to see if algebras work better when they are defined as homomorphisms of rings.