[PR #9368/02d8dba9 backport][3.10] Avoid using the proxy headers in the ConnectionKey if no proxy is in use #9378
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
bdraco
approved these changes
Oct 1, 2024
bdraco
reviewed
Oct 1, 2024
…d7539ca5fb6d93083bd26/pr-9368
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #9378 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 108 108
Lines 34888 34905 +17
Branches 4174 4176 +2
=======================================
+ Hits 34116 34133 +17
Misses 574 574
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
reviewed
Oct 1, 2024
bdraco
deleted the
patchback/backports/3.10/02d8dba9a320e4d15d8d7539ca5fb6d93083bd26/pr-9368
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9368 as merged into master (02d8dba).
What do these changes do?
Default proxy headers may be passed to the connector to be included in the event a proxy is being used. If no proxy is being used, we should not include the proxy auth and proxy headers in the
ConnectionKeysince it means we could end up creating a connection when one was already available for reuseAre there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no