Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target-version to black config (#9962) #9986

Conversation

asvetlov
Copy link
Member

Add target-version option to black config in pyproject.toml and
reformat code.

https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version
(cherry picked from commit 00fd4eb)

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Add `target-version` option to black config in `pyproject.toml` and
reformat code.

https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version
(cherry picked from commit 00fd4eb)
pyproject.toml Show resolved Hide resolved
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9986 will not alter performance

Comparing patchback/backports/3.11/00fd4eb62582caccfc721cb0c36e61f0350c2009/pr-9962 (3c218c4) with 3.11 (ee0657d)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@7af8bbf). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9986   +/-   ##
=======================================
  Coverage        ?   98.02%           
=======================================
  Files           ?      122           
  Lines           ?    36891           
  Branches        ?     4440           
=======================================
  Hits            ?    36164           
  Misses          ?      544           
  Partials        ?      183           
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (?)
OS-Linux 97.62% <100.00%> (?)
OS-Windows 94.52% <92.30%> (?)
OS-macOS 96.73% <100.00%> (?)
Py-3.10.11 96.59% <100.00%> (?)
Py-3.10.15 97.18% <100.00%> (?)
Py-3.11.10 97.20% <96.15%> (?)
Py-3.11.9 96.67% <96.15%> (?)
Py-3.12.7 97.69% <96.15%> (?)
Py-3.13.0 97.68% <96.15%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.10% <100.00%> (?)
Py-pypy7.3.16 96.65% <100.00%> (?)
VM-macos 96.73% <100.00%> (?)
VM-ubuntu 97.62% <100.00%> (?)
VM-windows 94.52% <92.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit 17b005a into 3.11 Nov 19, 2024
36 of 37 checks passed
@asvetlov asvetlov deleted the patchback/backports/3.11/00fd4eb62582caccfc721cb0c36e61f0350c2009/pr-9962 branch November 19, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants