Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bajnok97/34825 support overriding minio mc image template #359

Closed
wants to merge 2 commits into from
Closed

bajnok97/34825 support overriding minio mc image template #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982c7a7
Support overriding minio mc image in minio.yaml template.
Sep 26, 2024
b001e70
Merge branch 'main' into bajnok97/34825-support-overriding-minio-mc-i…
bajnok97 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion charts/airbyte/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ Helm chart to deploy airbyte
| metrics.tolerations | list | `[]` | Tolerations for metrics-reporter pod assignment, see https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ |
| minio.affinity | object | `{}` | Affinity and anti-affinity for minio pod assignment, see https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity |
| minio.image.repository | string | `"minio/minio"` | Minio image used by Minio helm chart |
| minio.image.tag | string | `"RELEASE.2023-11-20T22-40-07Z"` | Minio tag image |
| minio.image.tag | string | `"RELEASE.2023-11-20T22-40-07Z"` | Minio tag image

| minio.mc.image.repository | string | `"minio/mc"` | Minio Client image used by Minio helm chart |
| minio.mc.image.tag | string | `"latest"` | Minio Client tag image | |
| minio.nodeSelector | object | `{}` | Node labels for pod assignment, see https://kubernetes.io/docs/user-guide/node-selection/ # |
| minio.storage.volumeClaimValue | string | `"500Mi"` | |
| minio.tolerations | list | `[]` | Tolerations for minio pod assignment, see https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ # |
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte/templates/minio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ spec:
fsGroup: 1000
containers:
- name: minio-mc
image: airbyte/mc
image: "{{ .Values.minio.mc.image.repository }}:{{ .Values.minio.mc.image.tag }}"
command: ["/bin/sh", "-c",
"until (/usr/bin/mc config host add myminio $MINIO_ENDPOINT $MINIO_ACCESS_KEY $MINIO_SECRET_KEY) do echo '...waiting...' && sleep 1; done;
/usr/bin/mc mb --ignore-existing myminio/state-storage;
Expand Down
10 changes: 10 additions & 0 deletions charts/airbyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,6 +1723,13 @@ minio:
# -- Minio tag image
tag: RELEASE.2023-11-20T22-40-07Z

mc:
image:
# -- Minio Client image used by Minio helm chart
repository: minio/mc
# -- Minio Client tag image
tag: latest

storage:
volumeClaimValue: 500Mi

Expand All @@ -1737,6 +1744,9 @@ minio:
# -- Affinity and anti-affinity for minio pod assignment, see
# https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
affinity: {}




## @section cron parameters

Expand Down
Loading