Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Retire destination-bigquery-denormalized #28488

Merged
merged 35 commits into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2fd5ae5
Remove `destination-bigquery-denormalized`
evantahler Jul 19, 2023
cd97c20
metadata remains, but disabled repositories
evantahler Jul 19, 2023
f0f96f7
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Jul 20, 2023
aaa3d2d
bump version
evantahler Jul 20, 2023
f0b560b
use breakingChanges as a deprication hack
evantahler Aug 2, 2023
f518c38
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Aug 2, 2023
3964e0e
revert changes
evantahler Aug 2, 2023
a3613c9
revert
evantahler Aug 2, 2023
1fbb0a6
revert
evantahler Aug 2, 2023
385c7a9
downgrade to alpha + breaking change
evantahler Aug 2, 2023
7141fcc
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Aug 9, 2023
226761a
link to v2 docs
evantahler Aug 22, 2023
f0ae7ab
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Aug 22, 2023
ac9c965
upgrade guide
evantahler Aug 22, 2023
5178338
changelog
evantahler Aug 22, 2023
08b23b2
fix migration guide header
evantahler Aug 22, 2023
92732f5
fix dockerfile label
evantahler Aug 22, 2023
033d3e8
we still need isDefaultAirbyteTmpTableSchema
evantahler Aug 23, 2023
1789545
period
evantahler Aug 23, 2023
c7ad108
better migration note
evantahler Aug 23, 2023
a39ef42
fix quotes
evantahler Aug 23, 2023
aabdf73
Update bigquery-denormalized-migrations.md
evantahler Aug 28, 2023
7f8a3fd
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Aug 28, 2023
14b1059
fix test
evantahler Aug 28, 2023
74bdbb6
Automated Commit - Formatting Changes
evantahler Aug 28, 2023
55e8950
fix test
evantahler Aug 29, 2023
6b41a87
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Aug 30, 2023
1cf1f9d
remove from registries
evantahler Aug 30, 2023
aa38ea4
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Sep 6, 2023
60aaf97
add back to registry
evantahler Sep 6, 2023
9af3922
Update docs/integrations/destinations/bigquery-denormalized-migration…
evantahler Sep 6, 2023
e4021f6
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Sep 11, 2023
e758357
Use `dockerImageTag` to override the version running in cloud
evantahler Sep 12, 2023
d128d9c
Merge branch 'master' into evan/reomve-bigquery-denormalized
evantahler Sep 12, 2023
38cc904
revert custom registry tags
evantahler Sep 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ ENV APPLICATION destination-bigquery-denormalized

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=1.5.3
LABEL io.airbyte.version=2.0.0
LABEL io.airbyte.name=airbyte/destination-bigquery-denormalized
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: database
connectorType: destination
definitionId: 079d5540-f236-4294-ba7c-ade8fd918496
dockerImageTag: 1.5.3
dockerImageTag: 2.0.0
dockerRepository: airbyte/destination-bigquery-denormalized
githubIssueLabel: destination-bigquery-denormalized
icon: bigquery.svg
Expand All @@ -13,7 +13,12 @@ data:
enabled: true
oss:
enabled: true
releaseStage: beta
releases:
breakingChanges:
2.0.0:
message: "`destination-bigquery-denormalized` is being retired in favor of `destination-bigquery`, and is no longer maintained. Please switch to destination-bigquery, which will produce similar tables and contains many improvements. Learn more [here](https://docs.airbyte.com/release_notes/upgrading_to_destinations_v2/)."
upgradeDeadline: "2023-11-01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the sync pauser, after this date there should be no more running syncs on this destination - at which time (or maybe a little after, to give them the kick in the butt to move over to the new one once the syncs stop running) we can tombstone the connector (which tombstones their actors/connections) 👍🏻

releaseStage: alpha
resourceRequirements:
jobSpecific:
- jobType: sync
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ protected void assertNamespaceNormalization(final String testCaseId,
if (testCaseId.equals("S3A-1")) {
// bigquery allows namespace starting with a number, and prepending underscore
// will hide the dataset, so we don't do it as we do for other destinations
assertEquals("99namespace", actualNormalizedNamespace, message);
final int underscoreIndex = expectedNormalizedNamespace.indexOf("_", 1);
final String randomSuffix = expectedNormalizedNamespace.substring(underscoreIndex);
assertEquals("99namespace" + randomSuffix, actualNormalizedNamespace, message);
} else {
assertEquals(expectedNormalizedNamespace, actualNormalizedNamespace, message);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# BigQuery (denormalized typed struct) Migration Guide

## Upgrading to 2.0.0

`destination-bigquery-denormalized` is being retired in favor of `destination-bigquery`, and is no longer maintained. Please switch to `destination-bigquery`, which will produce similar tables and contains many improvements. We are retiring `destination-bigquery-denormalized` because it now heavily overlaps with Destinations V2, except for being slower and less reliable. Destinations V2 is now available for BigQuery. To learn more about the feature and speed improvements of Destinations V2, please [click here](https://docs.airbyte.com/release_notes/upgrading_to_destinations_v2)!
erohmensing marked this conversation as resolved.
Show resolved Hide resolved

This connector will be retired on November 1, 2023. Retired connectors will be removed from the Airbyte connector registry, and no new connections can be created with this connector. Your existing connection(s) will be disabled, with no possibility to re-eneable.
1 change: 1 addition & 0 deletions docs/integrations/destinations/bigquery-denormalized.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ See [destinations/bigquery](https://docs.airbyte.com/integrations/destinations/b

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :--------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------- |
| 2.0.0 | 2023-09-11 | [\#28488](https://github.com/airbytehq/airbyte/pull/28488) | Retire destination-bigquery-denormalized |
| 1.5.3 | 2023-07-14 | [\#28345](https://github.com/airbytehq/airbyte/pull/28345) | Increment patch to trigger a rebuild |
| 1.5.2 | 2023-07-05 | [\#27936](https://github.com/airbytehq/airbyte/pull/27936) | Internal code change |
| 1.5.1 | 2023-06-30 | [\#27891](https://github.com/airbytehq/airbyte/pull/27891) | Revert bugged update |
Expand Down
Loading