Updates docusaurus and GA to GA4 #29908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
approved these changes
Aug 28, 2023
supertopher
commented
Aug 28, 2023
| @@ -124,7 +116,7 @@ const config = { | |||
| customCss: require.resolve("./src/css/custom.css"), | |||
| }, | |||
| gtag: { | |||
| trackingID: "UA-156258629-2", | |||
| trackingID: "G-HDBMVFQGBH", | |||
There was a problem hiding this comment.
@nataliekwong I think this did all the magic
erohmensing
approved these changes
Sep 14, 2023
|
omg I didn't merge it 🤦 |
rebase changes All yarn packages upgraded Removed Broken Redirects Changes a string that calls a JS file to use GA4
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
supertopher
force-pushed
the
toph_makes_docs_GA4
branch
from
4cc2034 to
d603d8b
Compare
|
by the way - I think @timroes ended up integrating GA4 into the docs via Segment |
|
he did indeed, Evan is moving docs to vercel. He wanted to see if we could do this without script injection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All yarn packages upgraded
Removed Broken Redirects
Changes a string that calls a JS file to use GA4
revert-able.
tested locally
GA4 seen locally
pages loaded