Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: fix schemas #30091

Merged
merged 43 commits into from
Sep 20, 2023
Merged

Source Google Ads: fix schemas #30091

merged 43 commits into from
Sep 20, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Sep 1, 2023 •
edited
Loading

What

How

Fix primary keys to uniquely identify resources. Add foreign keys (id of parent resources ) to every stream.
https://developers.google.com/google-ads/api/docs/concepts/api-structure
https://developers.google.com/google-ads/api/docs/concepts/entity-relationships

Recommended reading order

Fixes in schemas

  1. integration_tests/configured_catalog
  2. source-google-ads/schemas/

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023 •
edited by tolik0
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 mentioned this pull request Sep 7, 2023
Merged
@tolik0 tolik0 force-pushed the tolik0/source-google-ads/fix-schemas branch from 19a6d68 to 86f358a Compare September 9, 2023 13:16
@tolik0 tolik0 force-pushed the tolik0/source-google-ads/fix-schemas branch from 9965ed4 to fa64207 Compare September 12, 2023 15:20
@github-actions
Copy link
Contributor

source-google-ads test report (commit fa642077fa) - ❌

⏲️ Total pipeline duration: 06mn15s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ❌
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@tolik0 tolik0 requested a review from lazebnyi September 12, 2023 15:50
@github-actions
Copy link
Contributor

source-google-ads test report (commit 749e1aefeb) - ❌

⏲️ Total pipeline duration: 05mn48s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@tolik0 tolik0 requested a review from bazarnov September 15, 2023 13:00
lazebnyi
lazebnyi reviewed Sep 15, 2023
View reviewed changes
airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py Outdated

class ShoppingPerformanceReport(IncrementalGoogleAdsStream):
"""
ShoppingPerformanceReport stream: https://developers.google.com/google-ads/api/fields/v11/shopping_performance_view
Google Ads API field mapping: https://developers.google.com/google-ads/api/docs/migration/mapping#shopping_performance
"""

primary_key = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so big PK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every segment should be part of primary key

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not set all fields to pk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted primary key

@github-actions
Copy link
Contributor

source-google-ads test report (commit d02ac55eef) - ✅

⏲️ Total pipeline duration: 06mn29s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@github-actions
Copy link
Contributor

source-google-ads test report (commit 3e6b5627ac) - ❌

⏲️ Total pipeline duration: 02mn50s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ❌ Failed (Inspect) Sep 19, 2023 9:15pm
docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:15pm

@github-actions
Copy link
Contributor

source-google-ads test report (commit 4aae6a4ef2) - ✅

⏲️ Total pipeline duration: 07mn12s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@github-actions
Copy link
Contributor

source-google-ads test report (commit bf407175ff) - ✅

⏲️ Total pipeline duration: 06mn50s

Step Result
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@tolik0 tolik0 merged commit f1537e8 into master Sep 20, 2023
18 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-schemas branch September 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@bazarnov bazarnov Awaiting requested review from bazarnov

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolik0 @lazebnyi @octavia-squidington-iii