Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove destination-bigquery-denormalized #30369

Merged

Conversation

evantahler
Copy link
Contributor

Following #28488, this PR now removes the connector from the registries so that no new connections can be created with it. This PR also removes all the code :D

@evantahler evantahler marked this pull request as ready for review September 12, 2023 21:23
@evantahler evantahler requested a review from a team as a code owner September 12, 2023 21:23
@evantahler evantahler changed the title Remove destination-bigquery-denormalized Remove destination-bigquery-denormalized Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

destination-bigquery-denormalized test report (commit bbb39d4822) - ❌

⏲️ Total pipeline duration: 28.59s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@github-actions
Copy link
Contributor

destination-bigquery-denormalized test report (commit bbb39d4822) - ❌

⏲️ Total pipeline duration: 12.40s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@evantahler
Copy link
Contributor Author

@bnchrch what bad things will happen if I merge this PR, both setting the registries to false and removing the code. It would be beneficial to the Destinations team remove the code early to stop having to worry about it...

@bnchrch
Copy link
Contributor

bnchrch commented Sep 12, 2023

@evantahler You know what, Im not sure what exactly will happen here!

I do know nothing terribly bad as we dont do anything like delete docker images or spec caches

Ideally

  1. The publish pipeline notices its already published the version in the metadata
  2. Skips the build step
  3. But still publishes the metadata.yaml

Actually im pretty sure that will be what happens.

So lets merge.

Worst case scenario it doesnt do that and

  1. I upload the metadata manually
  2. Celebrate that someone found an edge case while Im working in that area of the codebase

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to modify anything in airbyte-ci? (I didn't find anything via grep, just doublechecking)

assuming not, 🔪 kill this code

@evantahler evantahler force-pushed the evan/delete-destination-bigquery-denormalized branch from bbb39d4 to 4229d6b Compare September 25, 2023 16:48
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 4:53pm

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 4229d6b00c) - ❌

⏲️ Total pipeline duration: 25.83s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@evantahler
Copy link
Contributor Author

evantahler commented Sep 25, 2023

We haven't had a new destination-bigquery-denormalized connection on Cloud since Aug 1 (metabase). This should be safe to remove

@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 8333df392c) - ❌

⏲️ Total pipeline duration: 23.55s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="removing a connector... so yeah, tests are mad"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit de188be into master Sep 25, 2023
25 of 27 checks passed
@octavia-approvington octavia-approvington deleted the evan/delete-destination-bigquery-denormalized branch September 25, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants