Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨🚨 Source Zendesk Support: Remove stream Deleted Tickets #30440

Merged
merged 14 commits into from
Sep 19, 2023
Merged

🚨🚨 Source Zendesk Support: Remove stream Deleted Tickets #30440

merged 14 commits into from
Sep 19, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Sep 14, 2023 •
edited
Loading

What

remove stream Deleted Tickets

How

remove stream Deleted Tickets

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

Playbook: https://docs.google.com/document/d/11fajnxwjkEmsqpRytcbSwJQY__hwpxWatT9bphkxDqk/edit

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Zendesk Support: include deleted records in tickets Source Zendesk Support: Remove stream Deleted Tickets Sep 15, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 15, 2023
@artem1205 artem1205 changed the title Source Zendesk Support: Remove stream Deleted Tickets 🚨🚨 Source Zendesk Support: Remove stream Deleted Tickets Sep 15, 2023
@artem1205 artem1205 added the breaking-change Don't merge me unless you are ready. label Sep 15, 2023
@artem1205 artem1205 marked this pull request as ready for review September 15, 2023 14:49
@artem1205 artem1205 self-assigned this Sep 15, 2023
@github-actions
Copy link
Contributor

source-zendesk-support test report (commit ecb0eca877) - ❌

⏲️ Total pipeline duration: 31.53s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ❌
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@github-actions
Copy link
Contributor

source-zendesk-support test report (commit 61fa002273) - ❌

⏲️ Total pipeline duration: 07mn21s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@github-actions
Copy link
Contributor

source-zendesk-support test report (commit abb855f4d1) - ❌

⏲️ Total pipeline duration: 02mn51s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@github-actions
Copy link
Contributor

source-zendesk-support test report (commit 3a363fe4a6) - ❌

⏲️ Total pipeline duration: 11mn56s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205 @sherifnada
Update airbyte-integrations/connectors/source-zendesk-support/metadat…
5b95cc4 
…a.yaml

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@github-actions
Copy link
Contributor

source-zendesk-support test report (commit 5b95cc4e4d) - ❌

⏲️ Total pipeline duration: 07mn52s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205
Source Zendesk Support: update metadata deadline
75ad1f9
@artem1205
Merge remote-tracking branch 'origin/artem1205/source-zendesk-support…
b4cbcf1 
…-refactor-deleted-tickets' into artem1205/source-zendesk-support-refactor-deleted-tickets

# Conflicts:
#	airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
@github-actions
Copy link
Contributor

source-zendesk-support test report (commit b4cbcf15a8) - ❌

⏲️ Total pipeline duration: 01mn43s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@github-actions
Copy link
Contributor

source-zendesk-support test report (commit fec2554dd1) - ✅

⏲️ Total pipeline duration: 02mn46s

Step Result
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205 artem1205 merged commit d1d4f7c into master Sep 19, 2023
17 checks passed
@artem1205 artem1205 deleted the artem1205/source-zendesk-support-refactor-deleted-tickets branch September 19, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. connectors/source/zendesk-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem1205 @sherifnada @octavia-squidington-iii