Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Okta: migrate to low-code #36509

Merged
merged 26 commits into from
May 22, 2024
Merged

Conversation

pabloescoder
Copy link
Collaborator

Migrating Source Okta to YamlDeclarativeSource (Low-code) Airbyte CDK
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/6757

No breaking changes, I've tried to replicate everything that was there in the previous python based source. Since the source supported 2 methods of authentication, I have used a SelectiveAuthenticator. Both authentication methods needed the Authorization: SSWS header, which is not supported by the default Oauth2 and Bearer Authenticators (they add the Authorization: Bearer header) so I made custom components for the same.

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 3:10pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 26, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 26, 2024 21:08
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 26, 2024 21:09
@alafanechere alafanechere added the low-code-migration This connector has been migrated to the low-code CDK label Apr 3, 2024
@pabloescoder pabloescoder changed the title 🚨🚨 Source Okta: migrate to low-code ✨Source Okta: migrate to low-code Apr 6, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team April 11, 2024 05:15
@pabloescoder
Copy link
Collaborator Author

pabloescoder commented May 15, 2024

@tolik0
I've added the unit tests back. Added new unit tests for config migration, fixed the issue with the wrong primary keys, updated airbyte-cdk and expected records.
This PR is ready for review.

Also, could you please run airbyte-ci format locally and push those changes here?
I've ran the airbyte-ci format fix all command 4-5 times and even though it runs successfully locally, it is failing here in the pipelines.

@pabloescoder pabloescoder requested a review from tolik0 May 15, 2024 21:50
@lazebnyi
Copy link
Collaborator

lazebnyi commented May 16, 2024

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@pabloescoder
Copy link
Collaborator Author

The check for formatting errors pipeline is failing only on the unit_tests folder (which is excluded from the airbyte-ci path for formatting - see here)
All the other files are properly formatted so we can ignore that.

@tolik0 tolik0 merged commit cd93561 into master May 22, 2024
29 of 32 checks passed
@tolik0 tolik0 deleted the source-okta-migrate-to-lowcode branch May 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/okta low-code-migration This connector has been migrated to the low-code CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants