Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-woocommerce: ensure inline schemas, updated cdk, poetry, generate builder manifest #37289

Closed

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented Apr 13, 2024

This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:

  • auto-schema update -s all description: added descriptions to json and inline schemas
  • connector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifest
  • airbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docs
  • airbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentation
  • airbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.88.0) version

The version number and changelogs were also bumped using the connector-code pulls command.

Additionally a few changes were made on top of the above changes:

  • Generated manifest from builder, with embedded spec.
  • Removed old spec and schema files.
  • Added maxSecondsBetweenMessages to metadata.yaml
  • Fixed a couple CATs failing because we no longer have JSON schema/spec.

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 5:56pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/woocommerce labels Apr 13, 2024
@bleonard bleonard changed the title source-woocommerce: schema descriptions source-woocommerce: ensure inline schemas, updated cdk, poetry (where possible) Apr 20, 2024
@strosek strosek self-assigned this May 9, 2024
@strosek strosek requested review from lazebnyi, oustynova and a team as code owners May 17, 2024 01:24
@strosek strosek requested a review from girarda May 17, 2024 15:26
@strosek strosek changed the title source-woocommerce: ensure inline schemas, updated cdk, poetry (where possible) source-woocommerce: ensure inline schemas, updated cdk, poetry, generate builder manifest May 17, 2024
| 0.2.0 | 2022-11-30 | [19903](https://github.com/airbytehq/airbyte/pull/19903) | Migrate to low-code; Certification to Beta |
| 0.1.1 | 2021-11-08 | [7499](https://github.com/airbytehq/airbyte/pull/7499) | Remove base-python dependencies |
| 0.1.0 | 2021-09-09 | [5955](https://github.com/airbytehq/airbyte/pull/5955) | Initial Release. Source WooCommerce |
| 0.2.7 | 2024-05-14 | [37289](https://github.com/airbytehq/airbyte/pull/37289) | Updating to 0.88.0 CDK |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we published previous versions of the connector related to this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. But the number changes came from the automated scripts run by Brian.


[tool.poetry.dependencies]
python = "^3.9,<3.12"
airbyte-cdk = "0.88"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we hardcode from the minor version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxi297 told me it was better to keep the connector stable in case of future changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was decided here

It seems like we are now reconsidering this here

schema = stream.json_schema
if not schema:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move those changes to another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this change so the PR can run clean CATs, othrewise CI wouldn't pass. Is it OK to keep them?

fix typo in Readme

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
@strosek
Copy link
Contributor

strosek commented May 17, 2024

Closed to avoid conflicts with Brian's work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants