Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-stripe): add convert to concurrent stream #45701

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Sep 20, 2024

It can be sent for review after #45718

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

lazebnyi and others added 23 commits August 31, 2024 03:17
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:50am

@lazebnyi lazebnyi changed the title Lazebnyi/source stripe salesforce add convert to concurrent stream feat(source stripe) add convert to concurrent stream Sep 20, 2024
lazebnyi and others added 4 commits September 20, 2024 20:28
…rent-stream' of github.com:airbytehq/airbyte into lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 21, 2024
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Sep 21, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Sep 21, 2024
codeflash-ai bot added a commit that referenced this pull request Sep 21, 2024
… (`lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream`)

Here are several optimizations made to your script for improved runtime performance.

1. Reduced repeated conversions from `StreamSlice` to `Mapping`.
2. Removed redundant function calls and handled data structures more efficiently.
3. Optimized the use of `try-except` blocks.
4. Used more efficient iteration and data access methods.



The code has been refactored to eliminate repeated type checks, streamline the logic for selecting the next slice, and minimize unnecessary function calls. These changes should maintain the existing functionality while improving the runtime performance.
Copy link

codeflash-ai bot commented Sep 21, 2024

⚡️ Codeflash found optimizations for this PR

📄 Stream._get_checkpoint_reader() in airbyte-cdk/python/airbyte_cdk/sources/streams/core.py

📈 Performance improved by 134% (1.34x faster)

⏱️ Runtime went down from 66.6 microseconds to 28.4 microseconds

I created a new dependent PR with the suggested changes. Please review:

If you approve, it will be merged into this PR (branch lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream).

…rent-stream' of github.com:airbytehq/airbyte into lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
@lazebnyi lazebnyi changed the title feat(source stripe) add convert to concurrent stream feat(source-stripe) add convert to concurrent stream Oct 2, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 2, 2024
@lazebnyi lazebnyi changed the title feat(source-stripe) add convert to concurrent stream feat(source-stripe): add convert to concurrent stream Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants