-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-stripe): add convert to concurrent stream #45701
Draft
lazebnyi
wants to merge
43
commits into
master
Choose a base branch
from
lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(source-stripe): add convert to concurrent stream #45701
lazebnyi
wants to merge
43
commits into
master
from
lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
+350
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
…ield string validation
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
…ed' of github.com:airbytehq/airbyte into lazebnyi/cuncurrent-cdk-cursor-if-incremental-implemented
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
CDK
Connector Development Kit
connectors/source/stripe
connectors/source/salesforce
labels
Sep 20, 2024
lazebnyi
changed the title
Lazebnyi/source stripe salesforce add convert to concurrent stream
feat(source stripe) add convert to concurrent stream
Sep 20, 2024
…ert-to-concurrent-stream
…ert-to-concurrent-stream
…rent-stream' of github.com:airbytehq/airbyte into lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
codeflash-ai bot
added a commit
that referenced
this pull request
Sep 21, 2024
… (`lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream`) Here are several optimizations made to your script for improved runtime performance. 1. Reduced repeated conversions from `StreamSlice` to `Mapping`. 2. Removed redundant function calls and handled data structures more efficiently. 3. Optimized the use of `try-except` blocks. 4. Used more efficient iteration and data access methods. The code has been refactored to eliminate repeated type checks, streamline the logic for selecting the next slice, and minimize unnecessary function calls. These changes should maintain the existing functionality while improving the runtime performance.
⚡️ Codeflash found optimizations for this PR📄
|
…ert-to-concurrent-stream
…rent-stream' of github.com:airbytehq/airbyte into lazebnyi/source-stripe-salesforce-add-convert-to-concurrent-stream
lazebnyi
changed the title
feat(source stripe) add convert to concurrent stream
feat(source-stripe) add convert to concurrent stream
Oct 2, 2024
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Oct 2, 2024
lazebnyi
changed the title
feat(source-stripe) add convert to concurrent stream
feat(source-stripe): add convert to concurrent stream
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/salesforce
connectors/source/stripe
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be sent for review after #45718
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?