Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-mssql] improving discovery of large mssql database #46515

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

theyueli
Copy link
Contributor

@theyueli theyueli commented Oct 5, 2024

What

Partially fixes #42491

This is a cherry-pick of the change from this community PR
#43421

The purpose of this PR is to get this merged sooner due to an internal priority change. (There is a lack of response in the original PR)

How

From the original PR:

"If the connector is configured to synchronize only particular schemas the schema discovery step will download only columns of tables of each schema rather than downloading all columns for the whole database and then filtering down to necessary schemas."

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [X ] YES 💚
  • NO ❌

@theyueli theyueli added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Oct 5, 2024
@theyueli theyueli self-assigned this Oct 5, 2024
@theyueli theyueli requested a review from a team as a code owner October 5, 2024 21:49
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 9:57pm

@theyueli
Copy link
Contributor Author

theyueli commented Oct 5, 2024

/bump-version type=patch changelog="Improving discovery of large SQL server database."

Bump Version job started... Check job output.

✅ Changes applied successfully. (aac674e)

@postamar postamar merged commit edccd7d into master Oct 7, 2024
36 checks passed
@postamar postamar deleted the yue/fix-large-discover-mssql branch October 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql team/db-dw-sources Backlog for Database and Data Warehouse Sources team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-mssql] schema discovery fails with SQL error
4 participants