Bulk Load CDK Stream Incomplete Prefactor 2: Drop Queue Reader and Si… #46516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
MessageQueueReader
is factored away completelyMessageQueue
interface simplified from<KEY, MESSAGE>
to<MESSAGE>
. (This is because the next refactor will want an unkeyed queue, also it's just cleaner.)SizedMessageQueue
dropped, as well as the innerQueueChannel
; now there's just a simple defaultabstract
ChannelMessageQueue
class wrapping a kotlinChannel
KEY
part of the interface is now in aMessageQueueSupplier<KEY, MESSAGE>
, with a default supplier being wrapped records by stream descriptorReserved<DestinationRecordWrapped>>
MemoryManager
PR to make theReservation
into aReserved
wrapper for an associated typeReserved
is now acquired byMessageQueueWriter
and released bySpillToDiskTask
at the end of ause
blockAlso:
Note