up-to-date/base-image: cache dockerhub image listing #47447
Merged
+51
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/10-28-airbyte-ci/base-image_cache_dockerhub_image_listing
branch
from
3f90b17
to
f9990c2
Compare
alafanechere
changed the title
alafanechere
force-pushed
the
augustin/10-28-airbyte-ci/base-image_cache_dockerhub_image_listing
branch
2 times, most recently
from
197eba5
to
f129252
Compare
alafanechere
changed the title
This was referenced Oct 28, 2024
alafanechere
changed the base branch from
augustin/10-28-up-to-date_fix_quote_escape_in_workflow
to
graphite-base/47447
alafanechere
force-pushed
the
augustin/10-28-airbyte-ci/base-image_cache_dockerhub_image_listing
branch
from
f129252
to
4929d76
Compare
alafanechere
deleted the
augustin/10-28-airbyte-ci/base-image_cache_dockerhub_image_listing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
up-to-date: to find the latest base image we have to list all the base images available and fetch their digest. If this operation is not cached it can easily lead to DockerHub rate limiting issue.cache_ttl_secondsparameters to cache the interaction with thecraneclient. Inup-to-datewe set this cache TTL to 1 day.This pull request introduces a caching mechanism to avoid DockerHub rate limiting and updates various files to support this new feature. The most important changes include adding a cache TTL for base image listings, updating the
CraneClientand related methods to accept a cache TTL, and adding logging for digest fetching.Caching Mechanism:
airbyte-ci/connectors/base_images/README.md: Added a changelog entry for version 1.1.0, mentioning the cache TTL addition.airbyte-ci/connectors/base_images/base_images/utils/docker.py: Modified theCraneClientclass to accept acache_ttl_secondsparameter and updated thebare_containerinitialization to use this TTL.airbyte-ci/connectors/base_images/base_images/version_registry.py: Updated methods to pass thecache_ttl_secondsparameter to theCraneClient. [1] [2] [3] [4]airbyte-ci/connectors/pipelines/README.md: Documented the use ofcache_ttlfor base image registry listing in version 4.41.8.airbyte-ci/connectors/pipelines/pyproject.toml: Bumped the version to 4.41.8.Logging Enhancements:
airbyte-ci/connectors/base_images/base_images/utils/docker.py: Added logging statements for digest fetching to help identify bottlenecks and improve debugging.