Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use generated service get #1823

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat: use generated service get #1823

merged 1 commit into from
Sep 5, 2024
+130 −138

Conversation

byashimov
Copy link
Contributor

Usese ServiceGet from generated client. Requests secrets.

@byashimov byashimov force-pushed the byashimov-use-gen-service-get branch 5 times, most recently from 62eb28c to 332aead Compare September 3, 2024 11:31
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review September 4, 2024 06:57
@byashimov byashimov requested a review from a team as a code owner September 4, 2024 06:57
@byashimov
Copy link
Contributor Author

There is another ServiceGet call in WaitForServiceCreation, but:

  1. it doesn't need secrets
  2. the changes will be huge
    I'll make a sep PR for it.

@byashimov byashimov merged commit 4eb44a8 into main Sep 5, 2024
37 checks passed
@byashimov byashimov deleted the byashimov-use-gen-service-get branch September 5, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski