feat: add new data source for marking ext identities #1853
Merged
+237
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
from
2666058
to
fce949d
Compare
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
3 times, most recently
from
a40dc69
to
64f4015
Compare
rriski
requested changes
Sep 27, 2024
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
2 times, most recently
from
0c78b2f
to
f3dc2ff
Compare
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
internal/plugin/service/externalidentity/external_identity_data_source.go
Outdated
Show resolved
Hide resolved
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
from
f3dc2ff
to
30ffc6b
Compare
|
@staceysalamon-aiven @rriski Thank you both for the review. Comments should now be resolved. |
rriski
requested changes
Sep 30, 2024
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
from
30ffc6b
to
3212357
Compare
This data source can be used to mark external identity for organization user. This is a light weight method to map user from external service to aiven internal user.
roope-kar
force-pushed
the
rkar-support-governance-gitops
branch
from
3212357
to
b66ed98
Compare
rriski
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
Adds new data source "aiven_external_identity".
Why this way
This data source can be used to map external service user to internal aiven user.