fix: onBundleReady called before manifest is generated in build mode (#…

…221)
aklinker1 · Nov 18, 2024 · 69b44c5 · 69b44c5
1 parent 1e7b107
commit 69b44c5
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/packages/vite-plugin-web-extension/src/plugins/manifest-loader-plugin.ts b/packages/vite-plugin-web-extension/src/plugins/manifest-loader-plugin.ts
@@ -153,12 +153,14 @@ export function manifestLoaderPlugin(options: ResolvedOptions): vite.Plugin {
       });
     }
 
-    if (options.onBundleReady) {
+    await copyPublicDirToOutDir({ mode, paths });
+
+    // Handle the onBundleReady callback in dev mode here, as writeBundle is not called in dev mode
+    if (mode === BuildMode.DEV && options.onBundleReady) {
+      logger.verbose("Running onBundleReady");
       await options.onBundleReady();
     }
 
-    await copyPublicDirToOutDir({ mode, paths });
-
     // In dev mode, open up the browser immediately after the build context is finished with the
     // first build.
     if (mode === BuildMode.DEV && !options.disableAutoLaunch) {
@@ -287,6 +289,14 @@ export function manifestLoaderPlugin(options: ResolvedOptions): vite.Plugin {
       noInput.cleanupBundle(bundle);
     },
 
+    // Runs during: build, watch
+    async writeBundle() {
+      if (options.onBundleReady) {
+        logger.verbose("Running onBundleReady");
+        await options.onBundleReady();
+      }
+    },
+
     // Runs during: watch, dev
     async watchChange(id) {
       if (