Have simplified .union

akopachov · Dec 4, 2016 · e4a6b13 · e4a6b13
1 parent 2e4fa14
commit e4a6b13
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 29 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "mini-linq-js",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "LINQ for JavaScript library, which allows to work with arrays in a more easy way and focus on business logic.",
   "main": "dist/mini-linq.full.min.js",
   "authors": [

diff --git a/dist/mini-linq.full.min.js b/dist/mini-linq.full.min.js
diff --git a/dist/mini-linq.min.js b/dist/mini-linq.min.js
diff --git a/dist/mini-linq.with-knockout.min.js b/dist/mini-linq.with-knockout.min.js
diff --git a/dist/mini-linq.with-lazy.min.js b/dist/mini-linq.with-lazy.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "mini-linq-js",
-    "version": "1.3.0",
+    "version": "1.3.1",
     "description": "LINQ for JavaScript library, which allows to work with arrays in a more easy way and focus on business logic.",
     "homepage": "https://github.com/akopachov/mini-linq-js",
     "keywords": ["linq", "array"],

diff --git a/src/mini-linq.js b/src/mini-linq.js
@@ -572,29 +572,7 @@ SOFTWARE.
             },
 
             union: function(anotherCollection, comparator) {
-                if (typeof (comparator) === "string") {
-                    comparator = LINQ.utils.parseExpression(comparator);
-                } else if (typeof (comparator) !== "function") {
-                    comparator = function (a, b) { return a === b; }
-                }
-
-                var result = [];
-                var allValues = [].concat(this, anotherCollection);
-                for (var i = 0, l = allValues.length; i < l; i++) {
-                    var addToResult = true;
-                    for (var j = 0, rl = result.length; j < rl; j++) {
-                        if (comparator(allValues[i], result[j])) {
-                            addToResult = false;
-                            break;
-                        }
-                    }
-
-                    if (addToResult) {
-                        result.push(allValues[i]);
-                    }
-                }
-
-                return result;
+                return [].concat(this, anotherCollection).distinct(function(e) {return e}, comparator);
             },
 
             except: function(anotherCollection, comparator) {