Add support for more collection types #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made the changes and have tested them part from the "release-groups" collections. I though about adding tests but not sure if you'd want to test against actual MusicBrainz. Let me know if I should add some integration tests or change something. |
|
@alastair gentle ping. |
Signed-off-by: Ashhar Hasan <hashhar_dev@outlook.com>
hashhar
force-pushed
the
extended-collections
branch
from
57b5f0b to
abcc8cd
Compare
|
@alastair can you PTAL at this. |
thecnoNSMB
reviewed
Oct 1, 2022
|
|
||
| See `Browsing`_ for how to use `limit` and `offset`. | ||
| """ | ||
| return _do_collection_query(collection, "areas", limit, offset) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258
Signed-off-by: Ashhar Hasan hashhar_dev@outlook.com