Hotfix Finish support without parameter hotfixBranch #327
Conversation
basmussen
changed the title
| @@ -154,6 +154,31 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| throw new MojoFailureException("Hotfix branch with name '" + branch + "' doesn't exist. Cannot finish hotfix."); | |||
| } | |||
| hotfixBranchName = branch; | |||
| } else if (StringUtils.isBlank(hotfixVersion)) { | |||
There was a problem hiding this comment.
DISCLAIMER: I'm not a maintainer, so feel free to ignore what I'm saying. 😉
This is basically the same block as in GitFlowReleaseFinishMojo.
I wonder if it makes sense / is possible to avoid the duplicated code by, e.g., having an intermediate layer like AbstractGitFlowFinishMojo, which encloses this functionality. (Although it looks like GitFlowFeatureFinishMojo couldn't benefit from it.)
There was a problem hiding this comment.
Abstraction via inheritance is an obvious improvement since you write less code, right? But in many cases inheritance becomes much more inconvenient to maintain, than just copy some code, that has potential to diverge a little in the future.
If any, I would prefer using composition over inheritance everywhere. At least you can interchange the solution with a very less effort.
There was a problem hiding this comment.
Abstraction via inheritance is an obvious improvement since you write less code, right?
No, but thanks for ELI5. 😉
|
@aleksandr-m: Any news on this issue? The solution is already there? Can you review and merge it? |
Implementation of ticket #326. This allows to close a hotfix branch in batch mode without specifying the parameter hotfixBranch, if only one hotfix branch is available.