[log] Fix the crc checksum error cause by The MemoryLogRecordsArrowBuilder#getSizeInBytes() maybe modify the memory data after closed

[swuferhong]

Purpose

Linked issue: #152

Currently, if we use the default log format ARROW to write log, the crc checksum error in server will be thrown. After debug, I find the error is caused by the MemoryLogRecordsArrowBuilder#getSizeInBytes() method, it may cause CRC check error due to memory modifications after the builder is closed.

Tests

Add UT in MemoryLogRecordsArrowBuilderTest to verify.

API and Format

Documentation

No docs.

[swuferhong]

@wuchong @luoyuxia @loserwang1024 CI is passed, could you take a look at this pr.

[wuchong]

This will make the getSizeInBytes() inconsistent if getSizeInBytes() is called before close(). A clean solution:

Add a member variable boolean reCalculateSizeInBytes = false, and set it to true for append. And re-calculate the sizeInBytes in getSizeInBytes() if reCalculateSizeInBytes is true, and set it back to false in the end of getSizeInBytes().

[swuferhong]

This will make the getSizeInBytes() inconsistent if getSizeInBytes() is called before close(). A clean solution:

Add a member variable boolean reCalculateSizeInBytes = false, and set it to true for append. And re-calculate the sizeInBytes in getSizeInBytes() if reCalculateSizeInBytes is true, and set it back to false in the end of getSizeInBytes().

comments addressed

[swuferhong]

@wuchong comments addressed.

[wuchong]

LGTM.