only reserver ip instance after pod terminated #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 41.11% 41.38% +0.26%
==========================================
Files 42 42
Lines 2753 2757 +4
==========================================
+ Hits 1132 1141 +9
+ Misses 1501 1499 -2
+ Partials 120 117 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hhyasdf
added a commit
to hhyasdf/hybridnet
that referenced
this pull request
Sep 21, 2023
…ated only reserver ip instance after pod terminated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Describe what this PR does / why we need it
IPInstance reservation happens immediately after pod terminating now, so
preStopwill lose network connectivity because of this.Does this pull request fix one issue?
NONE
Describe how you did it
To avoid losing network connectivity when pre-stopping, we should reserve ip instance only after pod terminated, which means all containers of pod do not need network connectivity any more.
Describe how to verify it
Integration test will do this.
Special notes for reviews
NONE