backup and restore crontab file #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to do this with a crontab library? Seems dirty to write this feature in bash when it may not be necessary. |
|
I don't know about any simple libraries that just read and write to the system crontab. Imo the backing up part would be overkill with a library. |
|
Just looked and agree that there isn't a good library for this. |
alichtman
requested changes
Apr 3, 2020
escape any present " characters in the crontab line
alichtman
requested changes
Apr 7, 2020
alichtman
requested changes
Apr 7, 2020
|
Let's add some tests for this and then I'm good merging it in. |
alichtman
reviewed
Apr 8, 2020
alichtman
reviewed
Apr 8, 2020
alichtman
reviewed
Apr 8, 2020
| for x in f: | ||
| # the replace sanitizes the crontab line of any present " characters. | ||
| sanitized = x.replace('"', '\\"') | ||
| cmd = f"(crontab -l ; echo \"{sanitized}\") | sort - | uniq - | crontab -" |
There was a problem hiding this comment.
I'm also not convinced this is the best way to do this. This escaping may not work properly in all cases. Make sure to test it with some complex commands that require proper escaping.
Also maybe use shlex.quote()? https://docs.python.org/3.5/library/shlex.html#shlex.quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple solution for backing up and restoring the crontab. #215