Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 3 converter: addition of OTF V0s #23731

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ddobrigk
Copy link
Contributor

This commit (from @mhemmer-cern - super thanks!) adds a path for saving on-the-fly V0s in our converted AO2D. I'm marking this as draft for discussion and will still make a few minor changes (mccollisions version bump to 001, for instance) before marking ready for review.

mhemmer-cern and others added 3 commits October 10, 2024 08:52
- Added the Gamma Conversion V0s from the PWGGA
- Added a histogram to the PCM analysis to save the pT spectra of V0s before ANY cut
- When running over AODs the labels of the GammaConversion daughters need to be sorted. This can be done in the V0Reader task and with my latest changes also in the ConverterTask. To ensure that this is only done once there is a security check. This check was also updated inside the V0Reader.
- On the fly V0 table now uses truncation:
	- 11 bits for length and mass variables
	- 13 bits for momentum variables
- In case of AOD -> AO2D we can now use the AliConverionPhotonCuts class to cut on the on the fly V0s. This helps to reduce data size and ensures that we can use the same cuts for converting from AOD and ESD.
- Added possibility to convert on the fly V0s from ESD to AO2D. This requires the V0Reader class to be added to the analysis chain. Also we now need to specify what collision system is used `fCollSystem` via `SetCollSystem` and what the conversion cuts `fConversionCut` are via `SetConversionCut`
@ddobrigk ddobrigk marked this pull request as draft October 16, 2024 08:10
@alibuild
Copy link
Collaborator

f237b57: approval required: 1 of @FriederikeBock (Friederike Bock), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @fjonasALICE (Florian Jonas), @gconesab (Gustavo Conesa Balbastre), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @jokonig (Joshua Leon Konig), @kharlov (Yuri Kharlov), @ktf (Giulio Eulisse), @loizides (Constantinos Loizides), @mikesas (Mike Henry Petrus Sas), @nschmidtALICE (Nicolas Vincent Schmidt), @peressounko (Dmitri Peresunko), @policheh (Boris Polishchuk), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan); 1 of @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @mpuccio (Maximiliano Puccio), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

@alibuild
Copy link
Collaborator

ad23183: approval required: 1 of @FriederikeBock (Friederike Bock), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @fjonasALICE (Florian Jonas), @gconesab (Gustavo Conesa Balbastre), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @jokonig (Joshua Leon Konig), @kharlov (Yuri Kharlov), @ktf (Giulio Eulisse), @loizides (Constantinos Loizides), @mikesas (Mike Henry Petrus Sas), @nschmidtALICE (Nicolas Vincent Schmidt), @peressounko (Dmitri Peresunko), @policheh (Boris Polishchuk), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan); 1 of @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @mpuccio (Maximiliano Puccio), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

@ddobrigk
Copy link
Contributor Author

@mhemmer-cern when you get around to it, can you also write to this PR a message explaining the latest status of the data volume after all the reduction steps you took, since it's now much better? Thank you!!

@ddobrigk ddobrigk marked this pull request as ready for review October 18, 2024 16:31
@ddobrigk
Copy link
Contributor Author

@mhemmer-cern sorry to insist, but this is just a ping for you to report here on the size reduction you did - after which imho this could also be merged for testing. Tagging also @maciacco . Thank you!!

@mhemmer-cern
Copy link
Contributor

mhemmer-cern commented Oct 22, 2024

The reduction we saw was from 20% to 6% in PbPb data, just by truncation and cutting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants