Improve AliFJWrapper #23737
Improve AliFJWrapper #23737
Conversation
…ue for recursive depth is N=1 which corresponds to standard soft drop. Add settings for recursive depth, zCut and beta in the soft drop functionality
|
cf9ff90: approval required: 1 of @adriansev (Adrian Sevcenco), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @germainma (Marie Germain), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @lcunquei (Leticia Cunqueiro Mendez), @loizides (Constantinos Loizides), @matplo (Mateusz Ploskon), @mfasDa (Markus Fasel), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @raymondEhlers (Raymond James Ehlers), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan), @vkucera (Vit Kucera) Comment with |
|
8b1fd5a: approval required: 1 of @adriansev (Adrian Sevcenco), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @germainma (Marie Germain), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @lcunquei (Leticia Cunqueiro Mendez), @loizides (Constantinos Loizides), @matplo (Mateusz Ploskon), @mfasDa (Markus Fasel), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @raymondEhlers (Raymond James Ehlers), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan), @vkucera (Vit Kucera) Comment with |
|
Please gimme a couple of days to check on this (and ask for someone else to look it over). It looks fine at first glance, but changing something so deep in the jet framework needs careful checks If you don't hear anything in a few days, please ping me |
|
Sure. If you feel safer, I can also introduce the recursive soft drop functionality as its own function. Just felt a bit redundant. |
There was a problem hiding this comment.
Agreed that implementing it separately seems like a waste - I'm just worried given the late stage of AliPhysics that there may e.g. be a bug or difference in the RecursiveSoftDrop code vs the standard SoftDrop object. Let's see if something comes up when Florian reviews
| void SetRecursiveDepth(Int_t n) {fRecursiveDepth = n;} | ||
| void SetZCut(Double_t zCut) {fZcut = zCut;} | ||
| void SetBeta(Double_t beta) {fBeta = beta;} |
There was a problem hiding this comment.
I dug a little but can't find the answer yet, so in case you found out - we've e.g. varied the zcut in other measurements, so how did we use this in the past?
There was a problem hiding this comment.
I have no clue, I also try to find it. I guess everyone did it with using manual code. Also, the AliEmcalJetUtilitySoftDrop class is, in my opinion, not really useful for the SoftDrop analyses I found (at least it is not useful for my analysis, since it does not update the jet content - a second MR will follow after this one adding this functionality)
Replace SoftDrop in AliFJWrapper with RecursiveSoftDrop, standard value for recursive depth is N=1 which corresponds to standard soft drop. Add settings for recursive depth, zCut and beta in the soft drop functionality
Recursive Soft Drop with N=1 corresponds to standard soft drop: https://phab.hepforge.org/source/fastjetsvn/browse/contrib/contribs/RecursiveTools/trunk/README