Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add speedup_options cache #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Add speedup_options cache #857

wants to merge 1 commit into from

Conversation

singiamtel
Copy link
Collaborator

@singiamtel singiamtel commented Jun 27, 2024 •
edited
Loading

Checking which options are available is expensive, this way we only do
it once (as the git available in path is not expected to change during
execution)

Follow up to #849 (comment)

  • Check if there's any situation where this breaks (e.g. we construct the cache with the host machine's git, and then try to use unsupported flags from docker)

@singiamtel
Add speedup_options cache
6cd4660 
Checking which options are available is expensive, this way we only do
it once (as the git available in path is not expected to change during
execution)
@singiamtel singiamtel closed this Jul 19, 2024
@singiamtel singiamtel deleted the git_cache branch July 19, 2024 11:38
@singiamtel singiamtel restored the git_cache branch September 23, 2024 13:36
@singiamtel singiamtel reopened this Sep 23, 2024
@singiamtel
Copy link
Collaborator Author

Closed this accidentally when managing my own fork

@singiamtel singiamtel changed the title Add speedup_options cache WIP: Add speedup_options cache Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@singiamtel