Remove most Python 2 references #871
Merged
+54
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singiamtel
force-pushed
the
py2_gone
branch
from
cd471d8
to
9726442
Compare
ktf
reviewed
Sep 27, 2024
|
I'm also interested in improving some typings, should I keep those changes in a different PR or are they fine here? |
|
One thing at the time, this is already quite a lot of changes to review, albeit trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not ready to be merged, making PR to run the tests.
Also fixing some minor issues with the inheritance in
class Git(SCM)