fix: Impossible configure Alma if PS Account version is lower 5.0 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Francois-Gomis
approved these changes
Oct 24, 2024
This comment has been minimized.
This comment has been minimized.
|
⏳E2E tests are currently running. |
|
olance
reviewed
Oct 24, 2024
Comment on lines
631
to
+632
| $this->checkCompatibilityPSModule(); | ||
| $this->checkPsAccountCompatibility(); |
There was a problem hiding this comment.
The method names are a bit confusing, maybe you should:
- Only call
$this->checkPsAccountCompatibility();here - Rename
checkCompatibilityPSModuletocheckPSAccountsPresenceor something similar - Call it from
checkPsAccountCompatibilityas a first check
|
❌ E2E tests have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Code changes
We added a verification version of PS Account. If PS Account was lower that 5.0 PS Account Service returned an error that we didn't handle.
Now if the version is lower 5.0 we suggest to install the PS Account module (default message)
How to test
As a reviewer, you are encouraged to test the PR locally.
Install Ps Account lower that 5.0.
Install our module.
Try to configure it
Checklist for authors and reviewers
Non applicable