northd: Use reachable sset of 'ovn_lb_ip_set' when adding arp req lfl…

…ows.

When adding the arp req lflows in the 'ls_in_l2_lkup' stage for the
load balancer VIPs associated to a logical router we iterate through
the lb_ips sset of the router datapath.  For each ip of this sset we
check if this is reachable or not from any of the router ports.
We can instead use the reachable sset of ips (which is generated by
northd engine node).

Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>

northd/northd.c

@@ -8853,7 +8853,7 @@ build_lswitch_rport_arp_req_flows(struct ovn_port *op,
      */
 
     const char *ip_addr;
-    SSET_FOR_EACH (ip_addr, &op->od->lb_ips->ips_v4) {
+    SSET_FOR_EACH (ip_addr, &op->od->lb_ips->ips_v4_reachable) {
         ovs_be32 ipv4_addr;
 
         /* Check if the ovn port has a network configured on which we could
@@ -8866,7 +8866,7 @@ build_lswitch_rport_arp_req_flows(struct ovn_port *op,
                 stage_hint);
         }
     }
-    SSET_FOR_EACH (ip_addr, &op->od->lb_ips->ips_v6) {
+    SSET_FOR_EACH (ip_addr, &op->od->lb_ips->ips_v6_reachable) {
         struct in6_addr ipv6_addr;
 
         /* Check if the ovn port has a network configured on which we could