Content modelling/748 add review to edit #9735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
reviewed
Dec 12, 2024
| @@ -28,6 +28,9 @@ def valid_state?(state) | |||
| event :schedule do | |||
| transitions from: %i[draft], to: :scheduled | |||
| end | |||
| event :draft do | |||
There was a problem hiding this comment.
I wonder if this is a different in_review state here, rather than draft?
There was a problem hiding this comment.
the combination of using assign_attributes and valid? means we don't have to mess about with this now :)
this is consistent with structure we've used in other tests, and will allow us to add a `describe` block as we had more logic branches to it.
during the review stage, we want to check the scheduled values from the previous page are valid, but not yet put the edition into a scheduled or published state. here we validate there are no errors by updating the edition via the `assign_attributes` method which does not save the changes to the db.
Harriethw
force-pushed
the
content-modelling/748-add-review-to-edit
branch
from
67797cf to
9671e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/uMVUEObq/748-add-review-email-address-screen-as-part-of-the-edit-journey
Follow these steps if you are doing a Rails upgrade.