Redesign Licenses Screen #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # AltStore.xcodeproj/project.pbxproj # AltStore/Settings/LicensesViewController.swift # AltStore/Settings/Settings.storyboard
# Conflicts: # AltStore/Settings/Settings.storyboard
Closed
emrcftci
reviewed
May 27, 2020
| switch indexPath.row { | ||
| case 0: | ||
| cell.style = .top | ||
| break |
There was a problem hiding this comment.
We don't need to declare break. Please remove it.
emrcftci
reviewed
May 27, 2020
| break | ||
| case licenses.count - 1: | ||
| cell.style = .bottom | ||
| break |
There was a problem hiding this comment.
We don't need to declare break. Please remove it.
There was a problem hiding this comment.
Thank you for the review. You're right hehe.
Right now the PR can't be merged and since it has been opened for months without answer from Riley I'm not in a rush to update it. I will get to updating it eventually though and I will take your recommendation into account 😄
ortashadi
approved these changes
Sep 21, 2020
a0ahmad
approved these changes
Oct 31, 2020
rileytestut
force-pushed
the
develop
branch
2 times, most recently
from
c27e889
to
e7afa23
Compare
rileytestut
force-pushed
the
develop
branch
3 times, most recently
from
6eacbfc
to
e80a49e
Compare
7kom95
approved these changes
Aug 4, 2023
7kom95
approved these changes
Aug 4, 2023
7kom95
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(originally on #31):
I moved the PR because I updated the branch to follow Git Flow as the main repo.
I also accepted the suggestions made there.