Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEX bug test #1186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LEX bug test #1186

wants to merge 1 commit into from

Conversation

orimay
Copy link
Contributor

@orimay orimay commented Jan 12, 2022

Say, we have a list of props on a node:

aa
ab
ac

Then we query it like this:

{
  '.': {
    '*': 'a',
    '>': 'ab'
  }
}

The result we expect:

ab
ac

The result we get:

aa
ab
ac

Say, we have a list of props on a node:
aa
ab
ac

Then we query it like this: 
{
  '.': {
    '*': 'a',
    '>': 'ab'
  }
}

The result we expect:
ab
ac

The result we get:
aa
ab
ac
@amark
Copy link
Owner

amark commented Feb 4, 2022

👍 sounds like this is gonna be a win+win for everything, your other PR had smaller code, and this is a more sensible default that didn't add any complexity. I'm very impressed! Thanks for being willing to switch to ECMAscript5.

@bmatusiak
Copy link
Collaborator

@orimay we moved String.match() to lib/lex.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants