Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage reporting #1277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

expelledboy
Copy link

Follow up from #1024 split out code coverage reporting on npm test

@amark
Copy link
Owner

amark commented Sep 27, 2022

Oh here it is!!! Very cool. Ok, so do I need to do any thing furhter? Hadn't heard of nyc before, will check it out. Will this break CI or heroku if they don't have nyc installed?

@expelledboy
Copy link
Author

Why not run ci on PRs and get the info directly here?

But no it wont, because you npm install everything anyway, and I include nyc as a dev dep

Dont know about heroku. Is there a deployment of gun?

Copy link

@ViniciusFXavier ViniciusFXavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants