Add method Result.isSuccessfulNonEmpty() to verify that result is suc…

…cessful and non empty.
amatkivskiy · Jul 22, 2017 · bd33df2 · bd33df2
1 parent b42259c
commit bd33df2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/result/src/main/java/com/amatkivskiy/result/Result.java b/result/src/main/java/com/amatkivskiy/result/Result.java
@@ -23,6 +23,13 @@ public abstract class Result<V, E> {
    */
   public abstract boolean isEmpty();
 
+  /**
+   * @return true if successful non empty @{@link Result}, false otherwise.
+   */
+  public boolean isSuccessfulNonEmpty() {
+    return isSuccess() && !isEmpty();
+  }
+
   // Syntactic sugar
 
   /**

diff --git a/result/src/test/java/com/amatkivskiy/result/ResultTests.java b/result/src/test/java/com/amatkivskiy/result/ResultTests.java
@@ -235,6 +235,16 @@ public class ResultTests {
     assertThat(Result.<String, String>failure(OOOH_NOOO).or(OOOH_YEAH), is(OOOH_YEAH));
   }
 
+  @Test public void testIsSuccessfulAndEmptyCorrect() throws Exception {
+    assertThat(Result.success(null).isSuccessfulNonEmpty(), is(false));
+
+    assertThat(Result.success(1).isSuccessfulNonEmpty(), is(true));
+
+    assertThat(Result.failure(1).isSuccessfulNonEmpty(), is(false));
+
+    assertThat(Result.failure(null).isSuccessfulNonEmpty(), is(false));
+  }
+
   static class DefaultThrowerImpl<T> implements Function<T> {
     @Override public T call() {
       return null;