[data-provider] Decouple data retrieval from rendering #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiharR27
reviewed
May 30, 2022
| maxWidth: '100%', | ||
| width: size.str, | ||
| height: size.str, | ||
| borderRadius: (round === true ? '100%' : round) |
There was a problem hiding this comment.
@JorgenEvens - won't this pass false to borderRadius if round is false?
because borderRadius can't be a boolean i think
There was a problem hiding this comment.
If you pass false here, borderRadius will simply be removed from the final stylesheet so this doesn't pose a problem
There was a problem hiding this comment.
Concerns handled by #242
|
Also, can this be merged :) please @JorgenEvens |
calypsow777
reviewed
May 30, 2022
JorgenEvens
force-pushed
the
feature/decouple-rendering
branch
from
1825429
to
1dda1bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to fully customize how your avatars are rendered.
I'm hopeful this will resolve or provide an escape hatch for issues such as: