Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staticcheck issues #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timoa
Copy link

@timoa timoa commented Jan 15, 2023

Hi!

After running staticcheck on the project, it funds a few errors:

Deprecated

internal/tokenutil/tokenutil.go:16:19: jwt.StandardClaims is deprecated: Use RegisteredClaims instead for a forward-compatible way to access registered claims in a struct. (SA1019)
internal/tokenutil/tokenutil.go:31:19: jwt.StandardClaims is deprecated: Use RegisteredClaims instead for a forward-compatible way to access registered claims in a struct. (SA1019)

Unused

mongo/mongo.go:76:6: type nullawareDecoder is unused (U1000)
mongo/mongo.go:81:28: func (*nullawareDecoder).DecodeValue is unused (U1000)

Formatting

internal/tokenutil/tokenutil.go:46:16: error strings should not be capitalized (ST1005)
internal/tokenutil/tokenutil.go:59:16: error strings should not be capitalized (ST1005)
internal/tokenutil/tokenutil.go:71:14: error strings should not be capitalized (ST1005)

This PR will fix them, hopefully :)

@amitshekhariitbhu
Copy link
Owner

Thanks for this PR, I shall review, test everything and then proceed.

@ZeusMode
Copy link

This PR should be approved!

Yuri-SN added a commit to Yuri-SN/go-backend-clean-architecture that referenced this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants