Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/172 fix dependency overwriting #183

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

lheimbs
Copy link
Contributor

@lheimbs lheimbs commented Jan 17, 2024

This should now properly enable the coverage dependency.
It also increases the version number to 1.1 and changes the plugin id to be inline with the one on the gradle repository.

If one or two people are able to test this in the next few days and everything works we could maybe publish the new verison over the weekend.

Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good and the code is very well refactored! I would approve these changes so we can upload the new version. I have one question so let's say we will need to further change the override plugin. How can we distinguish between using the published plugin and the plugin publish to MavenLocal? Because for testing the changes I had to change everything back to io.github.amosproj.pitmutationmate.override.

@lheimbs
Copy link
Contributor Author

lheimbs commented Jan 18, 2024

I think this looks really good and the code is very well refactored! I would approve these changes so we can upload the new version. I have one question so let's say we will need to further change the override plugin. How can we distinguish between using the published plugin and the plugin publish to MavenLocal? Because for testing the changes I had to change everything back to io.github.amosproj.pitmutationmate.override.

There is no need to revert to the old naming:

  1. The version number was increased so unless you already increased it before it should not find 1.1 in the gradle repo and search MavenLocal
  2. The order in which you define the gradle pluginManagement repos in the settings.gradle matters. Put MavenLocal first and it will always use that one first instead of another repo. See here

Btw: i have added a content filter to my sample project's settings.gradle as suggested in the gradle docs.
This makes sure that only our projects are taken from mavenLocal and speeds up the build time (ever so slightly).

pluginManagement {
    repositories {
        mavenLocal {
            content {
                includeGroupByRegex("io\\.github\\.amos.*")
            }
        }
        gradlePluginPortal()
        google()
        mavenCentral()
    }
}

Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok everything is fine now!
Maybe you can add your last comment to the wiki page under the override plugin. These are helpful information for developers.

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
@lheimbs lheimbs force-pushed the Feature/172-fix-dependency-overwriting branch from 32e6755 to 68f880c Compare January 19, 2024 06:34
@lheimbs lheimbs merged commit 2a764cb into main Jan 19, 2024
16 checks passed
@lheimbs lheimbs deleted the Feature/172-fix-dependency-overwriting branch January 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants