-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/172 fix dependency overwriting #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good and the code is very well refactored! I would approve these changes so we can upload the new version. I have one question so let's say we will need to further change the override plugin. How can we distinguish between using the published plugin and the plugin publish to MavenLocal? Because for testing the changes I had to change everything back to io.github.amosproj.pitmutationmate.override
.
...oovy/io/github/amosproj/pitmutationmate/override/strategy/DependencyInclusionStrategy.groovy
Outdated
Show resolved
Hide resolved
...oovy/io/github/amosproj/pitmutationmate/override/strategy/DependencyInclusionStrategy.groovy
Outdated
Show resolved
Hide resolved
There is no need to revert to the old naming:
Btw: i have added a content filter to my sample project's settings.gradle as suggested in the gradle docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok everything is fine now!
Maybe you can add your last comment to the wiki page under the override plugin. These are helpful information for developers.
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
32e6755
to
68f880c
Compare
This should now properly enable the coverage dependency.
It also increases the version number to 1.1 and changes the plugin id to be inline with the one on the gradle repository.
If one or two people are able to test this in the next few days and everything works we could maybe publish the new verison over the weekend.