-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/156 add scope to run config #219
Conversation
brianneoberson
commented
Jan 29, 2024
- created a "Default" run config which will be used for the actionable pitest runs
- fixed the issue with the editing of run config settings. The editor now notices changes and they can be applied.
Co-authored-by: Liam Fogarty <lfogarty9995@gmail.com> Signed-off-by: brianneoberson <brianne.oberson@epfl.ch>
Signed-off-by: brianneoberson <brianne.oberson@epfl.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight concern that users will add their custom class paths in the Default
config then then wonder why they are gone after using some action...
...e/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/configuration/RunConfiguration.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that when I restart my IDEA, my run configuration persists, but the options I entered in the Gradle task and target classes are lost.
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com> Signed-off-by: Liam Fogarty <fogarty@ztm.de>
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com> Signed-off-by: Liam Fogarty <fogarty@ztm.de>
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com> Signed-off-by: Liam Fogarty <fogarty@ztm.de>
I am afraid we won't have time to find and implement a solution for this until tomorrow. But this could be a small ticket for next sprint. We fixed the other requested changes. |
Maybe a quick fix could be to make the default runconfig not editable? Or maybe write somewhere in the Default run config "Please don't change". |
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a simple solution to disable the targetClasses
field when it is the default run config. All other configs' fields are still editable.
Unfortunately, I can still edit the default run configuration. I can simply modify the targetClasses in the run configuration, and when I click on "run" the specified classes are executed. |
Did you remove the old one? Because that one obviously doesn't have the attribute set to true. Edit: Okay if one exists after first ide boot it doesn't have the attribute set and it is still editable, my bad. On it. |
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok works as expected!