Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/156 add scope to run config #219

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

brianneoberson
Copy link
Contributor

  • created a "Default" run config which will be used for the actionable pitest runs
  • fixed the issue with the editing of run config settings. The editor now notices changes and they can be applied.

Liam Fogarty and others added 2 commits January 24, 2024 17:41
Co-authored-by: Liam Fogarty <lfogarty9995@gmail.com>
Signed-off-by: brianneoberson <brianne.oberson@epfl.ch>
Signed-off-by: brianneoberson <brianne.oberson@epfl.ch>
Copy link
Contributor

@lheimbs lheimbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight concern that users will add their custom class paths in the Default config then then wonder why they are gone after using some action...

Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that when I restart my IDEA, my run configuration persists, but the options I entered in the Gradle task and target classes are lost.

Liam Fogarty and others added 3 commits January 30, 2024 17:19
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com>
Signed-off-by: Liam Fogarty <fogarty@ztm.de>
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com>
Signed-off-by: Liam Fogarty <fogarty@ztm.de>
Co-authored-by: Brianne Oberson <brianne.oberson@gmail.com>
Signed-off-by: Liam Fogarty <fogarty@ztm.de>
@brianneoberson
Copy link
Contributor Author

I have a slight concern that users will add their custom class paths in the Default config then then wonder why they are gone after using some action...

I am afraid we won't have time to find and implement a solution for this until tomorrow. But this could be a small ticket for next sprint. We fixed the other requested changes.

@nikomall34
Copy link
Contributor

Maybe a quick fix could be to make the default runconfig not editable? Or maybe write somewhere in the Default run config "Please don't change".

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Copy link
Contributor

@lheimbs lheimbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a simple solution to disable the targetClasses field when it is the default run config. All other configs' fields are still editable.

@nikomall34
Copy link
Contributor

Unfortunately, I can still edit the default run configuration. I can simply modify the targetClasses in the run configuration, and when I click on "run" the specified classes are executed.

@lheimbs
Copy link
Contributor

lheimbs commented Jan 30, 2024

Unfortunately, I can still edit the default run configuration. I can simply modify the targetClasses in the run configuration, and when I click on "run" the specified classes are executed.

Did you remove the old one? Because that one obviously doesn't have the attribute set to true.

Edit: Okay if one exists after first ide boot it doesn't have the attribute set and it is still editable, my bad. On it.

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok works as expected!

@lheimbs lheimbs merged commit 697052d into main Jan 30, 2024
15 checks passed
@lheimbs lheimbs deleted the Feature/156-add-scope-to-run-config branch January 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants