Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/221 file has multiple classes #237

Merged
merged 13 commits into from
Feb 6, 2024

Conversation

nikomall34
Copy link
Contributor

@nikomall34 nikomall34 commented Feb 6, 2024

In this PR, I also conducted some refactoring:

  1. I used a different layout for our runconfig settings editor because of the bug I mentioned in Bugfix/224 all kinds of fixes #233
  2. Inner classes are now included in the pitest run by appending a star (*) at the end of the fully qualified name (FQN). And I removed the gutter from inner classes
  3. The XMLParser is only invoked at startup and after a pitest run.
  4. The history tab now functions properly for Android projects as well.
  5. I had to change the coverage reporter because, in order to accumulate percentages for the LatestPitestReport, it's more convenient to utilize the pitest classes. So, I removed the className from the XML file since it was never utilized.

The results in the history tab are inaccurate; there are some bugs. However, due to time constraints, we are unable to address them as it would require input from the IP to make the correct design decisions.

After this PR is approved I will publish the Intellij plugin(BetatestVersion) and the coverage-reporter(Version 1.2)

nikomall34 added 13 commits February 5, 2024 17:13
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
…now only at LaunchActivity and after a pitest run
…rage-reporter accumulates the results for each file.

Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Signed-off-by: nikomall34 <niko.malliaros@fau.de>
…sproj/amos2023ws02-pitest-ide-plugin into Bugfix/221-file-has-multiple-classes

Signed-off-by: nikomall34 <niko.malliaros@fau.de>
… test files.

Signed-off-by: nikomall34 <niko.malliaros@fau.de>
…age information in the testfiles

Signed-off-by: nikomall34 <niko.malliaros@fau.de>
Copy link
Contributor

@lheimbs lheimbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works!

@nikomall34 nikomall34 merged commit bf10148 into main Feb 6, 2024
15 checks passed
@nikomall34 nikomall34 deleted the Bugfix/221-file-has-multiple-classes branch February 6, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants