Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added design documentation to week 13 deliverabels #238

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

QW3RAT
Copy link
Contributor

@QW3RAT QW3RAT commented Feb 6, 2024

Added pdf version of wiki page for the design documentation. Also changed the Design and Tech Stack pages to reflect the changes.

@QW3RAT QW3RAT marked this pull request as ready for review February 6, 2024 08:32
@nikomall34 nikomall34 self-requested a review February 6, 2024 13:13
Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 4.2.2 there are typos it is UDP instad of UPD. You can also parse the text in ChatGPT it will fix them and make it a bit more readable (I also do this with my texts ;))

The UDP does not communicate with the executor. The UDP-server is mainly there to check if the parameters were correctly overriden more specific just the targetClasses. The executor is a process started by intellij in which the command line that we built with the user input is executed. When the process is done the ExecutionDoneProcessListener.processTerminated function is called by intellij and this triggers actions like update the reports, archive the run,... (@lheimbs please correct me if I am wrong)

If you have time you can also add some stuff about the new task PitmuationmateStatusCheckTask in the override plugin. This task is executed in our intellij plugin before each pitest run to check if the necessary plugins are present.

@QW3RAT
Copy link
Contributor Author

QW3RAT commented Feb 6, 2024

Adressed changes requested by @nikomall34. Unfortunatly i dont have time before our meeting to add the mentioned PitmuationmateStatusCheckTask into the diagram and the description

@lheimbs
Copy link
Contributor

lheimbs commented Feb 6, 2024

There is still the UPD typo in the diagram as far as i can see

@QW3RAT
Copy link
Contributor Author

QW3RAT commented Feb 6, 2024

Thanks for checking, i uploaded the wrong version there
Should be fine now

@QW3RAT QW3RAT merged commit 12b4322 into main Feb 6, 2024
13 checks passed
@QW3RAT QW3RAT deleted the Homework/194-Finalize-design-documentation branch February 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants