Skip to content

Commit

Permalink
Backport of check error in TestDNSCycleRecursorCheckAllFail before as…
Browse files Browse the repository at this point in the history
…serting response to stop panic in CI. into release/1.17.x (hashicorp#20235)

* no-op commit due to failed cherry-picking

* check error in TestDNSCycleRecursorCheckAllFail before asserting response to stop panic in CI. (hashicorp#20231)

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: John Murret <john.murret@hashicorp.com>
  • Loading branch information
3 people authored Jan 17, 2024
1 parent ecb6ed0 commit 0e7c7e2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion agent/dns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,8 @@ func TestDNSCycleRecursorCheckAllFail(t *testing.T) {
m.SetQuestion("google.com.", dns.TypeA)
// Agent request
client := new(dns.Client)
in, _, _ := client.Exchange(m, agent.DNSAddr())
in, _, err := client.Exchange(m, agent.DNSAddr())
require.NoError(t, err)
// Verify if we hit SERVFAIL from Consul
require.Equal(t, dns.RcodeServerFailure, in.Rcode)
}
Expand Down

0 comments on commit 0e7c7e2

Please sign in to comment.