Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear memoized x509 cert on Cert#cert_pem assignment #10

Merged
merged 2 commits into from
Jul 15, 2024
Merged

clear memoized x509 cert on Cert#cert_pem assignment #10

merged 2 commits into from
Jul 15, 2024

Commits on Jun 26, 2024

  1. clear memoized x509 cert on Cert#cert_pem assignment 

    When a Puma::Acme::Cert is renewed, the new cert is assigned by calling
the cert_pem= method. The instance memoizes the parsed OpenSSL x509
object, but was not taking changes to the cert_pem into account. This
was causing renewed certs to keep using the old expir(ed/ing) cert
instead of the replacement. The pstore library is capable of marshaling
& unmarshaling the @x509 member, so this inconsistency is present in
instances loaded from the pstore cache.
    @benburkert
    benburkert committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a0c888b View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. drop ruby 3.1 syntax

    @benburkert
    benburkert committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d59a34f View commit details
    Browse the repository at this point in the history