Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify Polyfill PrivateAssets #148

Merged
merged 1 commit into from
Oct 1, 2024
Merged

simplify Polyfill PrivateAssets #148

merged 1 commit into from
Oct 1, 2024

Conversation

SimonCropp
Copy link
Contributor

PrivateAssets="all" /> is sufficient

andrewlock
andrewlock approved these changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm pretty sure this is just what Rider/dotnet SDK does by default? 🤔 Pretty sure I didn't explicitly do it 😅

@andrewlock andrewlock merged commit 4096966 into andrewlock:master Oct 1, 2024
3 checks passed
@SimonCropp SimonCropp deleted the simplify-Polyfill-PrivateAssets branch October 1, 2024 05:52
@SimonCropp
Copy link
Contributor Author

yeah u r correct. i just prefer the more succinct variant. and moving forward IDEs respect it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @andrewlock